(Dec 25, 2013 04:07 PM)imrankhan Wrote:  something wrong when the customers name come out.
something wrong when the customers name come out.

(Dec 25, 2013 04:41 PM)imrankhan Wrote:  problem is that when the user wants the information like id,name and balance, the name comes out in integers.Obviously the name is meant to come in string.

(Dec 25, 2013 04:45 PM)imrankhan Wrote:  g4143 do you understand the promblem?

---

thank you
omg i was trying to avoid that problem

---

and how po i improve the code, any suggestions?

(Dec 25, 2013 05:18 PM)Сlassy Wrote:  Don't use that big ass switch statement.

Do this:

PHP Code


<?php 
int k;
printf("what customer details do you want see");
scanf("%d", &k);

printf("The customers %d Name %s, ID %d and balance %d\n", k, st1[k].name, st1[k].id, st1[k].balance ); 


^ This can go out of bounds, but just throw it in an if statement and you're good to go.

Ex.

PHP Code


<?php 
int k;
printf("what customer details do you want see");
scanf("%d", &k);

if(k >= 1 && <= 10)
    printf("The customers %d Name %s, ID %d and balance %d\n", k, st1[k].name, st1[k].id, st1[k].balance );
else
    printf("Invalid input %d", k); 


(Dec 26, 2013 02:43 AM)TxTriton Wrote:  Why are you using k for indexing, if you continue with logic that dictates a 1-based array exists? If you're using k directly to index a value in the array and NOT k - 1, then shouldn't that be k >= 0, and k < 10?

Still, something seems off about this:

Code

if(k >= 1 && <= 10)

Wouldn't you think? :) [hint]if(k >= 1 && <= 10)[/hint]

Code

#include <stdio.h>

#define MAX_STUDENTS 10

typedef struct student
{
   int balance;
   int id;
   char name[20];
} student;

int main()
{
   student arr[MAX_STUDENTS];

   int i, k;
   for( i = 0; i < MAX_STUDENTS; i++ )
   {
  printf("Enter the customers %d Name ID and balance\n>>", i + 1);
  printf("Ex: John 1 250\n");
  scanf("%s %d %d", arr[i].name, &arr[i].id, &arr[i].balance);
   }
   getchar();

   printf("What customer details do you want see? [1-%d]\n", MAX_STUDENTS);
   if (!scanf("%d", &k) || (k > MAX_STUDENTS || k < 1))
   {
  printf("That is not a valid value...\n");
  return 1;
   }

   int index = k - 1;
   printf("The customers %d Name %s, ID %d and balance %d\n",
  k, arr[index].name, arr[index].id, arr[index].balance);

   getchar();
   getchar();
}

I didn't include much handling for invalid input, this isn't my assignment. But here's how I would start going about it... Actually, personally I'd probably just ditch scanf() and go with fgets(). There's lots of functions for parsing data to a wanted datatype. I don't really program in C anyways.

(Dec 26, 2013 04:06 AM)hoer- Wrote:  st1[9] should be st1[10] because there are 10 customers :)

(Dec 26, 2013 09:54 AM)Obsessed Wrote:  Uhm, no? Because arrays start at the 0 position, so it should be st1[9].

(Dec 26, 2013 11:07 AM)hoer- Wrote:  You must be confused, just because arrays start at 0 doesn't mean they should be defined like that. An array includes 0 as an element.
http://www.tutorialspoint.com/cprogramming/c_arrays.htm