(Nov 6, 2015 02:45 AM)Cathal Wrote:  Nothing jumps out at me immediately.. Can you post the source of ReadFile? By the way I strongly recommend you read this http://google-styleguide.googlecode.com/svn/trunk/javaguide.html

(Nov 6, 2015 02:49 AM)CubicMuffin Wrote:  Don't think it has anything to do with that but alright:

Code

public class ReadFile {
  
    private String path;
    
    public ReadFile(String file_path){
        path = file_path;
    }
    
    public String[] OpenFile() throws IOException{
        
        FileReader fr = new FileReader(path);
        BufferedReader textReader = new BufferedReader(fr);
        
        String[] textData = new String[10];
        
        for(int i = 0; i < textData.length; i++){
            textData[i] = textReader.readLine();
        }
        
        textReader.close( );
        return textData;
    }
}

Also any specific reason why I should read it (the guide)? Just so I know what I'm looking for if anything.

(Nov 6, 2015 02:56 AM)Cathal Wrote:  As far as I know, the BufferedReader class will automatically attempt to convert raw bytes to characters. The class is designed to read text, not binary. If you want to read the file as a string just use Scanner.

I asked you to look at Google's style guide because your code formatting is extremely inconsistent!

(Nov 6, 2015 02:59 AM)CubicMuffin Wrote:  It's text that I want. I read the binary in as a String, it just so happens the string is either going to be a "0" or a "1". Also it doesn't explain why textrfInput displays the correct string but bitInput which is literally told to be assigned the value of txtrfInput converts it to ASCII! Very confusing.

And I didn't think it was very inconsistent. If it's indentation you are talking about then copying and pasting code into here makes it mess up so I have to guess. Other than that, I thought it looked fine. (Also most of the first bit of code I sent you is still in testing so names etc aren't really going to be like that on the finished thing)

(Nov 6, 2015 03:14 AM)Cathal Wrote:  Yeah i understand ya now, to be honest I don't know how to help you, sorry man!

As for the formatting, it's not the indentation I was looking at. In one case you name a variable using snake_case (file_name), but you use camelCase just a bit later (txtInput).

In some places you leave a space before an opening curly bracket, but other times you don't.

Code

try {
...
catch (IOException e){

Lastly, it's common practice to use i, j and k for iterators or indices. Never x!

Obviously none of these are game-breaking problems but you should fix bad habits early.

(Nov 6, 2015 04:08 AM)Demmonic Wrote:  The only thing I can figure is that bitInput is a numerical array, causing the character to be casted to a number. You didn't post all of your code though, so I'm not sure.

(Nov 6, 2015 11:04 AM)CubicMuffin Wrote:  Heres the code for the main class.
Just a heads up, it's filled with random-ass comments because that's how I think :P You shouldn't really need to look at anything below the first input section.

(Nov 6, 2015 11:07 AM)Demmonic Wrote:  

Code

int[] bitInput = new int[256];

It prints the ASCII value because you've stored it in an int array, causing the JVM to treat it as an int. You can cast it back to print the character itself. Or just make it an array of characters.

Code

System.out.println("bI: " + (char)bitInput[x]);