+- Hack Forums (https://hackforums.net)
+-- Forum: Tech (https://hackforums.net/forumdisplay.php?fid=444)
+--- Forum: Coding (https://hackforums.net/forumdisplay.php?fid=151)
+---- Forum: Software Development (https://hackforums.net/forumdisplay.php?fid=118)
+---- Thread: [C#] [Theme] SatoshiMines (/showthread.php?tid=5291864)
[Theme] SatoshiMines - Blue Eyes - Jun 3, 2016
Hi , Here today I give my Theme Satoshi Mines
[img]http://image.prntscr.com/image/0827a656f3384ef6b4bc84ba959c0ff9.png[/img]
https://github.com/BlueEyesHF/SatoshiMines-Theme/
In case of problems please contact me on the forum, so I corrected it :)
* - Don Genovese - Jun 4, 2016
Thanks, it looks like a good theme!
* - Oliver Sykes - Jun 4, 2016
Seems decent.
Some criticism from someone who probably couldn't have done better:
1. Light blue and yellow buttons are kind of assaulting on the eyes
2. What's the blue box under the label?
3. Disabled button seems a bit...off
4. Not really criticism...but I'd recommend looking into rectangle rounding and gradients.
I'll update after glancing over the code.
Bear in mind, I'm a novice myself.
#L115, #L295, #L302, #L427:
Redundant; use autoproperties {get; set;}
Throughout the whole thing:
You may want to look into naming conventions for C#, as it's more readable to other devs
More verbose naming of variables doesn't hurt, so you may want to lengthen things like W and H a bit.
Actually, on that topic, why are you using W and H? Seems unnecessary if you lose readability to just a few extra letters typed only a couple of times.
* - Hawk HF - Jun 4, 2016
It looks very plain and the colors don't blend well.
I wouldn't use this on a product I was developing.
* - Blue Eyes - Jun 4, 2016
Official color satoshimine xD
I had no idea xD