(Aug 31, 2016 05:31 AM)My Computer Wrote:  Not bad, only suggestion I have for you is when using the Random class, don't create a new instance of it every time you need it. Instead you should only create one instance of it which can be accessed globally.

Example of what I mean:

Code

class Program
    {
        public static Random random;

        static void Main(string[] args)
        {
            random = new Random();
            int randNumber = RandomNumber(0, 10);

            Console.WriteLine("Your random number is: " + randNumber);
            Console.ReadKey();
        }

        public static int RandomNumber(int minValue, int maxValue)
        {
            return random.Next(minValue, maxValue);
        }
    }

Instead of:

Code

public static int RandomNumber(int minValue, int maxValue)
        {
            Random rand = new Random();
            int randNumber = rand.Next(minValue, maxValue);
            return randNumber;
        }

But anyways, good job on making this. 👍

(Aug 31, 2016 05:56 AM)Zilog80 Wrote:  Pro-tip #1:
No need compare boolean to "true" (or false):

PHP Code


<?php 
if (easyGuessMenuItem.Checked == true)
{
    userDifficulty = 10;
} 


Can be coded as:

PHP Code


<?php 
if (easyGuessMenuItem.Checked)
    userDifficulty = 10;
else if (mediumGuessMenuItem.Checked)
    userDifficulty = 7;
... 


Pro-tip #2:

That @My Computer said

Hope it helps 🤝

(Aug 31, 2016 06:11 AM)LaPanthere Wrote:  Kinda weird to see Convert.ToString being used.
Any reason you are using it?

I'd personally do something like:

PHP Code


<?php 
(userDifficulty - userGuess).ToString(); 


Quote:Perhaps make an extension method for 'ToInt' or such as well?

Quote:Perhaps instead of using menu checkboxes use a sequence of radio buttons?

Quote:frmMain/Game would perhaps be a better name for the form?
(I'd do FrmMain as that's my coding style).

Quote:Just a few tips anyway, hopefully they help in some way.

Btw with your VT scan don't fret. 360 picks up some .net files without reasons.

(Aug 31, 2016 06:22 AM)VirtualFrost Wrote:  Convert.ToString is (or now was) the only way I knew how to convert those integers to strings so that they could be used inside my Label, is there a difference between the two, or are you more used to doing it that way?

(Aug 31, 2016 06:22 AM)VirtualFrost Wrote:  Could you expand on this? What do you mean by make an extension method for 'ToInt'?

Spoiler (Click to View)

(Aug 31, 2016 06:56 AM)Zilog80 Wrote:  After changing As spoiler you get "real version":



Hope it helps :)

(Aug 31, 2016 07:09 AM)LaPanthere Wrote:  Just remember, the IDE has a thing on Project Properties -> Application -> Assembly Information...

https://i.imgur.com/SKjduMq.png

(Aug 31, 2016 06:35 AM)LaPanthere Wrote:  Convert.ToString just simply calls ToString on the value so it is exactly the same.

PHP Code


<?php 
public static string ToString(int value)
{
    return value.ToString(CultureInfo.CurrentCulture);
} 


You can create your own 'Extension' classes that you can simply 'stringAsNum.ToInt()'

https://msdn.microsoft.com/en-us/library/bb383977.aspx


Glad to help :)

(Aug 31, 2016 06:56 AM)Zilog80 Wrote:  Hehe, glad to help too 😁

Another pro-tip:

Pro-tip #3: i'm agree with @LaPanthere that radio buttons would be more suitable. But anyway if you still use menu toolstrips (not bad at all) you could change your clearMenuChecked to:

PHP Code


<?php 
private void clearMenuChecked()
{
    foreach (ToolStripMenuItem ítem in difficultyToolStripItem.DropDownItems)
    {
        item.Checked = false;
    }
} 


This for-each loop set checked to false to all difficultyToolStripItem items. So doesn't matters how many difficulty levels you have.

Pro-tip #4: if you change your version (Current Version: 1.1.0) you should change your assembly info:

Spoiler (Click to View)



After changing As spoiler you get "real version":



Hope it helps :)