(Jan 31, 2018 02:03 PM)HFDone Wrote:  wmi is good to do hard things easy the only problem is speed

(Jan 31, 2018 02:11 PM)Hoodie+ Wrote:  Does this work for .NET 2.0?
I know that .NET 2.0 doesn't support querying WMI, or at least I've heard.

(Jan 31, 2018 02:11 PM)Hoodie+ Wrote:  Does this work for .NET 2.0?
I know that .NET 2.0 doesn't support querying WMI, or at least I've heard.

(Jan 31, 2018 09:49 PM)Ninja Wrote:  Its been a while since someone released code that I enjoyed reading through. This is some good code. Thanks for the release, buddy!

---

Pretty sure WMI itself works under 2.0, but not sure if OPs project works under 2.0.

(Feb 3, 2018 12:41 PM)0xDEAD10CC Wrote:  Just FYI you can do expression bodied properties:

Code

public bool IsReadOnly => false;

Instead of this in C#:

Code

public bool IsReadOnly
{
   get => false;
}

And your WmiClass could make use of some ref returns (C#7)

Code

public WmiProperty[] Properties { get; }

public ref WmiProperty this[string propertyName]
{
   get
   {
       for (int i = 0; i < Properties.Length; i++)
       {
           if (Properties[i].Name.Equals(propertyName, StringComparison.Ordinal))
           {
               return ref Properties[i];
           }
       }
       
       string ex_msg = $"The specified property '{propertyName}' does not exist.";
       throw new IndexOutOfRangeException(ex_msg);
   }
}

Also much better to use Equals() for string comparison and define your comparison.

You've overcomplicated some of your util functions though such as GetHexString().

Not terrible code overall though. For something like this though you could probably make more use of abstract classes and interfaces for something which definitely has a hierarchy.

(Feb 4, 2018 05:08 AM)chrizator Wrote:  Thanks for the advice. It's great to have people on hear that actually read code and share their experience. I'll try to adapt my code ASAP.
Btw, I'm wondering how much of a difference Equals() makes instead of comparing the object references.

(Feb 4, 2018 08:49 AM)0xDEAD10CC Wrote:  You're not comparing references when you use == on strings because it's overloaded.

Increased speed and recommended by Microsoft since 2005: https://msdn.microsoft.com/en-us/library/ms973919?f=255&MSPPError=-2147217396
Avoid problems like this from time to time with other reference types: https://blogs.msdn.microsoft.com/csharpfaq/2004/03/29/when-should-i-use-and-when-should-i-use-equals/

It's more of a common habit for developers as well and makes it explicit as to what kind of string comparison you're doing. Also, if you want to compare references there's already a ReferenceEquals function too so you don't have to worry about this overloading. It's okay to use == and others on value types though as they don't overload these operators by default.