(Nov 4, 2018 08:36 AM)turbosoggy Wrote:  The design is really stunning. One thing i found is that the main page dosent 404 properly, for example demo.cryptoexchange-software.us/riuwahriuya just displays the main page instead of a 404

(Nov 6, 2018 03:37 PM)Abruptum Wrote:  The result would be a remote file inclusion attack against line :
https://github.com/GMX9/Crypto-Exchange-PHP/blob/master/lib/controllers.php#L36

(Nov 6, 2018 03:37 PM)Abruptum Wrote:  Just wanted to say that there is a potential vulnerability in your code for the php version <5.3.4 due the handling of null bytes in the file_exists function.
https://github.com/GMX9/Crypto-Exchange-PHP/blob/master/lib/controllers.php#L34
The result would be a remote file inclusion attack against line :
https://github.com/GMX9/Crypto-Exchange-PHP/blob/master/lib/controllers.php#L36
if possible you should check your  directory "modules" and then check if the name is contained in the directory over scandir(http://php.net/manual/de/function.scandir.php) if not then not even check the if the files exists.

or you can create a runtime check if the current php version is higher than >5.3.4 .

A small little patch should be done here also :
https://github.com/GMX9/Crypto-Exchange-PHP/blob/master/lib/userconnect.php#L152
sha1 is far to uncomplex, a 1-6 digit sha1 hash can be cracked within 49 minutes or less, so use sha256.

(Nov 6, 2018 08:15 PM)Exp500 Wrote:  To allow remote inclusion allow_url_include must be set to On in php.ini

But yeah, this is a bad approach, you should never use unfiltered external input in file inclusion

(Nov 7, 2018 03:51 AM)AMX6 Wrote:  Thanks alot for your input mate !
Submited a fix related the path, check it out if you can.

Regarding the sha1 ill update it later today

Check this out :
https://github.com/GMX9/Crypto-Exchange-PHP/commit/ce3b670c6a53b65312300902d175b639e62f0f22

---

Yes was really bad of me, i let it pass completly unaware, i already sanitized the param and submited a fix with scandir

(Nov 7, 2018 04:07 AM)Abruptum Wrote:  I meaned that you could implement it in a way like this :

PHP Code


<?php 
$dirs = scandir("modules/");
$found = false;
foreach ($dirs as $dir){
    if($name == $dir && is_dir("modules/$dir")){
        $found = true;
        break;
    }
}
if($found && file_exists("modules/$name/controller/$name.php")){
    require_once("modules/$name/controller/$name.php");
    $module->index();
}else{
    require_once("modules/index/controller/index.php");
    $module->index();
} 


You should not use htmlentities or $connect->real_escape_string to secure when you want to search for a file it can lead to several problems regarding special characters which could be allowed.

(Nov 7, 2018 04:42 AM)AMX6 Wrote:  Thanks again ! I already submited your edit to the main repo !
https://github.com/GMX9/Crypto-Exchange-PHP/commit/ce3b670c6a53b65312300902d175b639e62f0f22

What do you think generally of the organization and my mvc ?

(Nov 7, 2018 05:47 AM)Abruptum Wrote:  The organisation is done quite nice, sometimes even a bit overkill :D

(Nov 7, 2018 07:39 AM)AMX6 Wrote:  :D thanks alot bud ! Let me know if ur interested in making something with me, you seem like a very good programmer , if u want just drop me a pm 🤝

(Mar 3, 2019 05:01 AM)GMX9 Wrote:  New Update Released:
Website : cryptoexchange-software.us