(Jan 26, 2019 07:42 AM)Exp500 Wrote:  Is $target_file_p the one being used for the upload of the image as in the script? It looks like "../uploads/Photos" is missing a / before the filename

PHP Code


<?php 
$dir_p       = "../uploads/Photos/"; 


(Jan 26, 2019 08:50 AM)Babadook Wrote:  Thank you so much. I knew it'd be something simple like that.

(Jan 26, 2019 07:16 AM)Babadook Wrote:  Edit: Edited original post with a new issue. x2

For some reason this assigns the first $var instead of sorting by the file extension.
Example: When I upload a png it should be assigned a $var = 3;
However, it goes to the first fileType it comes to and is assigned a $var = 1;

PHP Code


<?php 
if (isset($_POST["submit"])) {
    if (filesize($_FILES["fileToUpload"]["tmp_name"]) < $df) { //gets free space)
        $uploadOk = 1;
        $error    = 1;
        if ($fileType == "epub" || $fileType == "mobi" || $fileType == "pdf" || $fileType == "azw" || $fileType == "lit") {
            $var   = 1;
            $error = 2;
            goto midBreak;
        } elseif ($fileType == "wav" || $fileType == "mp3" || $fileType == "ac3" || $fileType == "flac" || $fileType == "ape" || $fileType == "aac" || $fileType == "m4a") {
            $var   = 2;
            $error = 3;
            goto midBreak;
        } elseif ($fileType == "bmp" || $fileType == "png" || $fileType == "jpg" || $fileType == "jpeg" || $fileType == "gif") {
            $var   = 3;
            $error = 4;
            goto midBreak;
        } elseif ($fileType == "apk" || $fileType == "exe" || $fileType == "bat" || $fileType == "app" || $fileType == "vb") {
            $var   = 4;
            $error = 5;
            goto midBreak;
        } elseif ($fileType == "mp4" || $fileType == "ogg" || $fileType == "wmv" || $fileType == "avi" || $fileType == "webm" || $fileType == "mov") {
            $var   = 5;
            $error = 6;
            goto midBreak;
        } elseif ($fileType == "sh" || $fileType == "php") { //Blocks potentially harmful files
            $error = 7;
            goto theEnd;
        } else {
            $error = 8;
 goto dir0Upload;
        }
    } else {
        $fEnd = 1;
        goto sizeFailure;
    }
} 


(Feb 1, 2019 11:41 AM)+Haze Wrote:  Just a heads up buddy, it's deemed bad programming practice to use goto statements in your code. It creates spaghetti code that becomes increasingly difficult to read and maintain.

Also,

Code

($fileType == "mp4" || $fileType == "ogg" || $fileType == "wmv" || $fileType == "avi" || $fileType == "webm" || $fileType == "mov")

is a bit messy, try something like.

Code

function isExtensionValid($fileType, $validExtensions) {
     foreach($validExtenions as $ext) {
          if ($ext == $fileType) {
              return true;    
           }
     }

     return false;
}

That way you can just do

Code

if (isExtensionValid($fileType, ["mp4", "ogg" , "wmv" , "avi" , "webm" , "mov"]) {
    $var   = 4;
    $error = 5;
    callFunction();
}

I wrote this on top of my head so it may not fully work, but this approach makes it easier to maintain and read your code.

(Feb 1, 2019 04:00 PM)Abruptum Wrote:  x

(Feb 1, 2019 07:23 PM)Babadook Wrote:  Thank all of you for your help. I'll start testing your suggestions. If it's not obvious by now, I'm teaching myself as I go. The goto statements, I know that nobody likes them, but without them, my code ran through all of my if statements whether they were true or false so I needed something to skip the codes it didn't need. Hopefully I can get everything working without them. Thank you again!