+- Hack Forums (https://hackforums.net)
+-- Forum: Tech (https://hackforums.net/forumdisplay.php?fid=444)
+--- Forum: Coding (https://hackforums.net/forumdisplay.php?fid=151)
+---- Forum: Software Development (https://hackforums.net/forumdisplay.php?fid=118)
+---- Thread: [Java] 3D TIC TAC TOE AI (/showthread.php?tid=5577924)
3D TIC TAC TOE AI - FinnTheHuman - Mar 17, 2017
https://github.com/OntologicalSin/3D-Tic-Tac-Toe
This is a game I created. I haven't updated it in a while, and haven't really shown it to anyone, as I dont know whether or not its something to be proud of.
Please let me know what you think, any constructive criticism, praise, or straight criticism is greatly appreciated. I am a high school student working to become a software engineer or another person in the field of computer science.
* - Stealth™ - Mar 22, 2017
There's a lot of criticism to give regarding this.
Code
/*
* @param: none
* @return: the board that was populated
*/
public int getBoard()
{return boardX;}Javadoc comments don't follow proper conventions, neither does brace-spacing.
Code
if(turnlog.letMeKnow(turnlog.getP1Turns()) && !turnlog.letMeKnow(turnlog.getP2Turns()))
{
Location loc = turnlog.getNeed(turnlog.getP1Turns());
if((!turnlog.getP1Turns().contains(loc)&&!turnlog.getP2Turns().contains(loc))&&!loc.equals(new Location(0,0)))
returnMe = loc;
else
{
returnMe = last();
}
}Spacing within conditions is inconsistent with proper conventions and the rest of the program, and omitting braces for if-statemenets.
Not utilizing the final identifier in Location.java, as well as in other classes.
Not packaging the program into folders, etc. Everything is pretty sloppy.
* - FinnTheHuman - Mar 24, 2017
(Mar 22, 2017 07:31 PM)Stealth™ Wrote: There's a lot of criticism to give regarding this.But in terms of substance?
Code/*
* @param: none
* @return: the board that was populated
*/
public int getBoard()
{return boardX;}
Javadoc comments don't follow proper conventions, neither does brace-spacing.
Codeif(turnlog.letMeKnow(turnlog.getP1Turns()) && !turnlog.letMeKnow(turnlog.getP2Turns()))
{
Location loc = turnlog.getNeed(turnlog.getP1Turns());
if((!turnlog.getP1Turns().contains(loc)&&!turnlog.getP2Turns().contains(loc))&&!loc.equals(new Location(0,0)))
returnMe = loc;
else
{
returnMe = last();
}
}
Spacing within conditions is inconsistent with proper conventions and the rest of the program, and omitting braces for if-statemenets.
Not utilizing the final identifier in Location.java, as well as in other classes.
Not packaging the program into folders, etc. Everything is pretty sloppy.
* - Stealth™ - Mar 24, 2017
(Mar 24, 2017 04:20 PM)FinnTheHuman Wrote: But in terms of substance?
What do you mean by that?
* - udpcon - Mar 24, 2017
(Mar 24, 2017 04:53 PM)Stealth™ Wrote: What do you mean by that?
I think he's asking you if you think his application is good despite the syntactical inconsistencies.
* - Stealth™ - Mar 24, 2017
(Mar 24, 2017 06:44 PM)udpcon Wrote: I think he's asking you if you think his application is good despite the syntactical inconsistencies.
Oh, I'm too lazy to download and run it lol.
* - clrlslwi - Mar 26, 2017
(Mar 24, 2017 07:13 PM)Stealth™ Wrote: Oh, I'm too lazy to download and run it lol.
Ah, got us a top tier Stealth response right here. Too stupid to even into reading comprehension.
* - 3clipse - Mar 26, 2017
(Mar 24, 2017 07:13 PM)Stealth™ Wrote: Oh, I'm too lazy to download and run it lol.
Some HQ posts here guys, he's the best java developer ever!
* - FinnTheHuman - Mar 26, 2017
(Mar 26, 2017 10:17 AM)3clipse Wrote: Some HQ posts here guys, he's the best java developer ever!
This has been noticed by me as well, knowledge of syntax clearly reflects experience in software development(being sarcastic, but I do understand that a programmer who doesn't know how to properly communicate isn't a very good programmer)
* - Stealth™ - Mar 26, 2017
(Mar 26, 2017 10:05 AM)Demmonic Wrote: Too stupid to even into reading comprehension.
What?
(Mar 26, 2017 10:17 AM)3clipse Wrote: Some HQ posts here guys, he's the best java developer ever!
I know :)
* - 3clipse - Mar 26, 2017
(Mar 26, 2017 10:49 AM)FinnTheHuman Wrote: This has been noticed by me as well, knowledge of syntax clearly reflects experience in software development(being sarcastic, but I do understand that a programmer who doesn't know how to properly communicate isn't a very good programmer)
Yeah, and when they act like they're the shit all because they paid like $20 to write some stupid certification exam doesn't help.
Oh and when they go to community college and spew whatever their lecturer is saying without actually understanding what he's talking about
* - FinnTheHuman - Mar 27, 2017
(Mar 26, 2017 09:20 PM)3clipse Wrote: Yeah, and when they act like they're the shit all because they paid like $20 to write some stupid certification exam doesn't help.
Oh and when they go to community college and spew whatever their lecturer is saying without actually understanding what he's talking about
Do you have any qualifications? (Stealth might not but do you?)
* - 3clipse - Mar 27, 2017
(Mar 27, 2017 09:47 AM)FinnTheHuman Wrote: Do you have any qualifications? (Stealth might not but do you?)
I have an actual job in the field, and I went to a real school.