[FinnTheHuman]

https://github.com/OntologicalSin/3D-Tic-Tac-Toe

This is a game I created. I haven't updated it in a while, and haven't really shown it to anyone, as I dont know whether or not its something to be proud of.

Please let me know what you think, any constructive criticism, praise, or straight criticism is greatly appreciated. I am a high school student working to become a software engineer or another person in the field of computer science.

[Stealth™]

There's a lot of criticism to give regarding this.

Code

/*
* @param: none
* @return: the board that was populated
*/
public int getBoard()
{return boardX;}

Javadoc comments don't follow proper conventions, neither does brace-spacing.

Code

if(turnlog.letMeKnow(turnlog.getP1Turns()) && !turnlog.letMeKnow(turnlog.getP2Turns()))
{
    Location loc = turnlog.getNeed(turnlog.getP1Turns());
    if((!turnlog.getP1Turns().contains(loc)&&!turnlog.getP2Turns().contains(loc))&&!loc.equals(new Location(0,0)))
        returnMe = loc;
    else
    {
        returnMe = last();
    }
}

Spacing within conditions is inconsistent with proper conventions and the rest of the program, and omitting braces for if-statemenets.

Not utilizing the final identifier in Location.java, as well as in other classes.

Not packaging the program into folders, etc. Everything is pretty sloppy.

[FinnTheHuman]

There's a lot of criticism to give regarding this.

Code

/*
* @param: none
* @return: the board that was populated
*/
public int getBoard()
{return boardX;}

Javadoc comments don't follow proper conventions, neither does brace-spacing.

Code

if(turnlog.letMeKnow(turnlog.getP1Turns()) && !turnlog.letMeKnow(turnlog.getP2Turns()))
{
    Location loc = turnlog.getNeed(turnlog.getP1Turns());
    if((!turnlog.getP1Turns().contains(loc)&&!turnlog.getP2Turns().contains(loc))&&!loc.equals(new Location(0,0)))
        returnMe = loc;
    else
    {
        returnMe = last();
    }
}

Spacing within conditions is inconsistent with proper conventions and the rest of the program, and omitting braces for if-statemenets.

Not utilizing the final identifier in Location.java, as well as in other classes.

Not packaging the program into folders, etc. Everything is pretty sloppy.

But in terms of substance?

[Stealth™]

But in terms of substance?

What do you mean by that?

[udpcon]

What do you mean by that?

I think he's asking you if you think his application is good despite the syntactical inconsistencies.

[Stealth™]

I think he's asking you if you think his application is good despite the syntactical inconsistencies.

Oh, I'm too lazy to download and run it lol.

[clrlslwi]

Oh, I'm too lazy to download and run it lol.

Ah, got us a top tier Stealth response right here. Too stupid to even into reading comprehension.

[3cli‌‌pse]

Oh, I'm too lazy to download and run it lol.

Some HQ posts here guys, he's the best java developer ever!

[FinnTheHuman]

Some HQ posts here guys, he's the best java developer ever!

This has been noticed by me as well, knowledge of syntax clearly reflects experience in software development(being sarcastic, but I do understand that a programmer who doesn't know how to properly communicate isn't a very good programmer)

[Stealth™]

Too stupid to even into reading comprehension.

What?

Some HQ posts here guys, he's the best java developer ever!

I know :)

[3cli‌‌pse]

This has been noticed by me as well, knowledge of syntax clearly reflects experience in software development(being sarcastic, but I do understand that a programmer who doesn't know how to properly communicate isn't a very good programmer)

Yeah, and when they act like they're the shit all because they paid like $20 to write some stupid certification exam doesn't help.

Oh and when they go to community college and spew whatever their lecturer is saying without actually understanding what he's talking about

[FinnTheHuman]

Yeah, and when they act like they're the shit all because they paid like $20 to write some stupid certification exam doesn't help.

Oh and when they go to community college and spew whatever their lecturer is saying without actually understanding what he's talking about

Do you have any qualifications? (Stealth might not but do you?)

[3cli‌‌pse]

Do you have any qualifications? (Stealth might not but do you?)

I have an actual job in the field, and I went to a real school.