Should be interesting. Thank you for sharing this with the community.
(Mar 2, 2015 06:27 PM)Nikey646 Wrote: For anyone who is interested: The password is !YouGotThePassword!
P.S: OP, test your password's Encoding's to make sure they work correctly. Oh, and you post the Decryption order, not the Encryption order last time i checked.
Edit: Looking at the source, it's sub-par at best. You use the EOF compilation method if i'm correct? Why not use Codedom, and generate a .resx file with the supplied data, then provide it to the source. Much cleaner, no writing to the end of Stubs, and no additional .exe files with the builder.
Looking at the stub....It's a form with a transparency key? You would of been better off creating a Console Application, and setting it to a Windows Application project type, you won't have an entire WinForms application running then. If this was coded in C# you could also intercept the Program class and rather than starting the application, run your code there.
Downloading the file via My.Computer.Network? At least use a WebClient....
redundant code -- your write basically the same code TWICE once for Temp Folder and once for Appdata, rather than using Path.Combine to set a Base Directory, then Path.Combine to set the Directory + Filename, meaning you would only need to write the code once, and you wouldn't need to call Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData) or Path.GetTempPath() multiple times.
more redundant code -- you use If and ElseIf to set the MessageBox Icon (Not even providing a No Icon option!), rather than using Enum.TryParse() to get the value from the string, and pass that along into the MessageBox.Show()
Your stub code doesn't compile with Option Strict On, but unlike most releases here, the errors is just a minimal 2. One about conversion of a Int64 to an Int32, and the other about using an Int64 as a Boolean....wai.
but worst of all, your "delay" is a Thread.Sleep on the UI Thread...If the delay is large enough, i'm fairly sure it'll appear as "Not Responding" in Task Manager throwing HUGE warning flags to any user who looks at Task Manager...
Overall: It could be worse. It could make use of some modern techniques (Codedom), since you are not concerned with the stub being FUD, you should also look into Multi-Threading or Async/Await + Task.Delay(), and reduce your redundant code
This, and instead of dropping the bytes, run the bytes straight in memory
|