[+Haze]

Thanks mate, glad you like it :D

[Jire]

I like this. It can be improved by allowing custom animations.

Your animations already implement TrayAnimation which is great. Unfortunately you directly map these to an enum and in your notification code only allow these enum values. Also unfortunately you re-access the map based on the enum value in order to use the interface.

Instead I suggest changing the notification code to accept TrayAnimation and then have your enum implement TrayAnimation. (One way to do this is have each enum value take an instance of one of the appropriate animation type.) This gives end-users the ability to add their own animations while still retaining ease of use via the enum values. With these changes you are also able to remove AnimationProvider entirely (the boilerplate in the enum is made up for!).

Hope I helped and feel free to add me on Skype (you or anybody else who wants to) if you need any Java help: tgpn1996

[+Haze]

I like this. It can be improved by allowing custom animations.

Your animations already implement TrayAnimation which is great. Unfortunately you directly map these to an enum and in your notification code only allow these enum values. Also unfortunately you re-access the map based on the enum value in order to use the interface.

Instead I suggest changing the notification code to accept TrayAnimation and then have your enum implement TrayAnimation. (One way to do this is have each enum value take an instance of one of the appropriate animation type.) This gives end-users the ability to add their own animations while still retaining ease of use via the enum values. With these changes you are also able to remove AnimationProvider entirely (the boilerplate in the enum is made up for!).

Hope I helped and feel free to add me on Skype (you or anybody else who wants to) if you need any Java help: tgpn1996

I totally agree with you, whilst creating this I saw that flaw but I didn't know how I could of changed the messy dependency of the having to add every new object that implemented TrayAnimation object.

Sadly, I don't know how to implement what you've said. I'll give it a try and if I can't get it to work I'll PM you or Skpye you ;) Thaks.

Nice to know some knowledgeable java devs here -> HF needs members like you

[+Haze]

I like this. It can be improved by allowing custom animations.

Your animations already implement TrayAnimation which is great. Unfortunately you directly map these to an enum and in your notification code only allow these enum values. Also unfortunately you re-access the map based on the enum value in order to use the interface.

Instead I suggest changing the notification code to accept TrayAnimation and then have your enum implement TrayAnimation. (One way to do this is have each enum value take an instance of one of the appropriate animation type.) This gives end-users the ability to add their own animations while still retaining ease of use via the enum values. With these changes you are also able to remove AnimationProvider entirely (the boilerplate in the enum is made up for!).

Hope I helped and feel free to add me on Skype (you or anybody else who wants to) if you need any Java help: tgpn1996

Sorry I've re-read what you said and when I try implement it, I just don't understand what I'm supposed to do. Firstly I didn't even know enums could implement an absrtact interface

[SlopeQ]

This program was very good, and with a nice GUI. I like it, keep it up :)

[+Haze]

Thanks man I appreciate it :D

[+Haze]

Bumping this so more people can see

[Jire]

Nice project, looking to do some more work to it. Feel free to add my Skype for better discussion.

[+Haze]

Yeah that would be nice, I have completely not worked on this project since the day I made this thread. I've always wanted to make it better as I saw potential in it, I've always wanted to make it into a full blown thing that can be used by many but never found time.

Yes I'll PM you my Skype, I'd like feedback and improvements from someone that knows their stuffs, don't find many like that on HF.

[Jire]

Yeah that would be nice, I have completely not worked on this project since the day I made this thread. I've always wanted to make it better as I saw potential in it, I've always wanted to make it into a full blown thing that can be used by many but never found time.

Yes I'll PM you my Skype, I'd like feedback and improvements from someone that knows their stuffs, don't find many like that on HF.

Do you have a license in mind for this project?

I completed a significant pull request for the following features:

• Build tool support via Maven
  
• Travis CI support
  
• Added ability to define custom animations
  
• Added ability to define custom notification types
  
• Simplified internals, simplified API
  
• Added unit testing

Link to my fork: https://github.com/Jire/TrayNotification

[๖ۣۜAnubis]

Looks great. Keep the good work.

[+Haze]

Do you have a license in mind for this project?

I completed a significant pull request for the following features:

• Build tool support via Maven
  
• Travis CI support
  
• Added ability to define custom animations
  
• Added ability to define custom notification types
  
• Simplified internals, simplified API
  
• Added unit testing

Link to my fork: https://github.com/Jire/TrayNotification

Thanks and nah never really messed with licensing much.

---

Looks great. Keep the good work.

Thanks mate I appreciate it :D

[Zuro]

Nice amount of hacked accounts stars on your repo, fam.
...S-S-Stack-O-O-Overflow-in, ObscureCodez

[+Haze]

Nice amount of hacked accounts stars on your repo, fam.
...S-S-Stack-O-O-Overflow-in, ObscureCodez

-__- he ruined my repo by botting the stars. Oh wells.

[Zuro]

-__- he ruined my repo by botting the stars. Oh wells.

You love it really, fam. It's funny tbh.
In another one of your replies, please don't refer to Stack as a "pro". He is not a pro. But don't tell him that (what am I kidding, I want him to find this post and call me a faggot on skype).

It's all good though since GitHub is shit anyway. It's not really used in the real world as a proper SCM by like large companies (large companies buy into using but they only really use it as a mirror repo from their own team foundation or subversion or, if it's not some edgy company, their own git servers). tl;dr - GitHub is a portfolio and CV piece, not an SCM.