[x64]

Hello everyone,

So I had to make a little program for a test on school.
And this program needed to replace text in files.
You could choose between directories/subdirectories etc.
And some of you might need some help with that. So I decided to post it on HF.

Here is the class:

Code

public class FileReplace
    {
        public delegate void FileProcessed(string fileName, string replace, Dictionary<int, string> linesReplaced);
        public event FileProcessed FileProcessedHandler;

        public void Replace(string search, string replace, string path, bool subDirectories = false, bool caseSensitive = false)
        {
            if (Directory.Exists(path) || File.Exists(path))
            {
                if (Path.HasExtension(path))
                {
                    ReplaceFile(path, search, replace, caseSensitive);
                }
                else
                {
                    var files = Directory.GetFiles(path, "*.*", subDirectories ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly);
                    foreach(var file in files)
                    {
                        ReplaceFile(file, search, replace, caseSensitive);
                    }
                }
            }
        }


        private void ReplaceFile(string path, string search, string replace, bool caseSensitive)
        {
            if (File.Exists(path))
            {
                var file = File.ReadAllLines(path);
                search = caseSensitive ? path.ToLower() : search;
                var linesReplaced = new Dictionary<int, string>();
                for (int l = 0; l < file.Length; l++)
                {
                    var line = caseSensitive ? file[l].ToLower() : file[l];
                    if (line.Contains(search))
                    {
                        file[l] = file[l].Replace(search, replace);
                        linesReplaced.Add(l, file[l]);
                    }
                }
                File.WriteAllLines(path, file);
                FileProcessedHandler(path, replace, linesReplaced);
            }
        }

    }

Please say what I could improve or what I did good 😊

[BahNahNah]

Your case insensitive search makes the entire line lowercase. You could do something like this:

Spoiler (Click to View)

[Hawk HF]

Your case insensitive search makes the entire line lowercase. You could do something like this:

Spoiler (Click to View)

Waittt... I feel like I remember you bitching about same-line brackets. 😝

[BahNahNah]

Waittt... I feel like I remember you bitching about same-line brackets. 😝

Ikr.

I was ment to work on a project with someone that would only use same line brackets, so I switched vs to it and never changed it back. + that I'm learning golang which won't compile unless the brackets are on the same line.

There is an argument for both styles, but I do like the compactness of same line.

[Hawk HF]

Ikr.

I was ment to work on a project with someone that would only use same line brackets, so I switched vs to it and never changed it back. + that I'm learning golang which won't compile unless the brackets are on the same line.

There is an argument for both styles, but I do like the compactness of same line.

I've actually switched to new line brackets for the same reason lol.
It's just a standard where I work.

[Sn0wX]

Your case insensitive search makes the entire line lowercase. You could do something like this:

Spoiler (Click to View)

No you should not do some thing like that fucktard. Lets ignore the fact it's to hard for you to post in the correct section.

Do not try to teach others when you have not even read bloody msdn for the methods you use. String.Equals Method (String, StringComparison) is already overloaded to handle case. Try reading first https://msdn.microsoft.com/en-us/library....110).aspx

You also use tolower and have no idea what its meant for....


As explained in Best Practices for Using Strings in the .NET Framework, we recommend that you avoid calling string casing methods that substitute default values and instead call methods that require parameters to be explicitly specified. To convert a character to lowercase by using the casing conventions of the current culture, call theToLower(CultureInfo) method overload with a value of CultureInfo.CurrentCulture for its culture parameter.


But how can we expect any thing from you when you cant post VB in a vb section.

[BahNahNah]

No you should not do some thing like that fucktard. Lets ignore the fact it's to hard for you to post in the correct section.

Do not try to teach others when you have not even read bloody msdn for the methods you use. String.Equals Method (String, StringComparison) is already overloaded to handle case. Try reading first https://msdn.microsoft.com/en-us/library....110).aspx

You also use tolower and have no idea what its meant for....

But how can we expect any thing from you when you cant post VB in a vb section.

I was not aware that string.Equals supported case insensitive comparison, so thanks for pointing that out.

I diddnt say should, i said could. Im very aware that my code is not optimized, it was just concept code to present other ways of doing things.

OPs code was c#, so i provided c#.

[gigajew]

Your case insensitive search makes the entire line lowercase. You could do something like this:

Spoiler (Click to View)

Don't you mean if(CaseInsensitive) ?