[skull]

Hi Python masters 🤝

I am having a weird issue, I have this:

Code

    file = open(proxyList ,'r')
    proxies = file.read()
    file.close()
    proxies = [s.strip() for s in proxies.splitlines()]

    file = open(notWorkingProxyList ,'r')
    notWorkingProxies = file.read()
    file.close()
    notWorkingProxies = [s.strip() for s in notWorkingProxies.splitlines()]

    print proxies
    print notWorkingProxies

    for x in proxies:
        if x in notWorkingProxies:
            proxies.remove(x)
        else:
            print 'Proxy [' + x + '] is ok to use.'

    print proxies

The output from that is the following:

Code

['187.32.4.66:8080', '202.162.217.3:8080']
['187.32.4.66:8080', '202.162.217.3:8080']
['202.162.217.3:8080']

I don't really get why it outputs the IP at the end? Shouldn't it be an empty array?
I expect it to be an empty array, any idea what I am doing wrong?

[.kr.]

you got an issue, because you edit the list you iterate on....


try this:

Code

file = open(proxyList ,'r')
proxies = file.read()
file.close()
proxies = [s.strip() for s in proxies.splitlines()]

file = open(notWorkingProxyList ,'r')
notWorkingProxies = file.read()
file.close()
notWorkingProxies = [s.strip() for s in notWorkingProxies.splitlines()]

print proxies
print notWorkingProxies


for x in [p for p in proxies]:
    if x in notWorkingProxies:
        proxies.remove(x)

print proxies

[skull]

you got an issue, because you edit the list you iterate on....


try this:

Code

truncated

Thanks, that solved my issue. I will remember to do this in the future.
Really appreciate the help.

[.kr.]

this is the same with a little less code:

Code

proxyList = "proxy.txt"
notWorkingList = "nw.txt"

def toList(file):
    with open(file) as f:
        return [x.strip() for x in f.read().strip().split()]

proxies = toList(proxyList)
notWorking = toList(notWorkingList)

for x in [p for p in proxies if p not in notWorking]:
    print x

[skull]

this is the same with a little less code:

Code

proxyList = "proxy.txt"
notWorkingList = "nw.txt"

def toList(file):
   with open(file) as f:
       return [x.strip() for x in f.read().strip().split()]

proxies = toList(proxyList)
notWorking = toList(notWorkingList)

for x in [p for p in proxies if p not in notWorking]:
   print x

Thats much better, its easier to understand when I can name the functions myself 👍

[Infamia]

Code

with open("proxy.txt") as working, open("nw.txt") as not_working:
  working = set(map(str.strip, working))
  not_working = set(map(str.strip, not_working))

for proxy in (working - not_working):
  print(proxy)

should work, haven't tested it.
does a simple set subtraction on working from not_working.