Guesstimated based on small amount of songs tested while optimizing the code.
Has about a .75% chance of getting the song. Based on my experience.
5% of the time it finds a different song with the same title (not really a fault, probably should search with artists name or something). 20% of the time it doesn't download because of the youtube-mp3 problems.
Not bad, but needs a new method to be efficient currently. xD
I post my opinions, please try not to be offended... I am not saying I am superior, but my interpretation of what you are saying may be befuddling.
Wow this is a pretty good way of getting songs, great app :D
Thanks for this, Im god aweful at VB and was wondering if you could add proxy support? Im guessing that this is illegal but im not sure lol.
Thanks for this bro,i love it 🤗🤗🤗
Really nice program however i have found a few bugs. One involving the correct save pathing. as well as a second bug that doesn't download the right song. infact when i was trying to download one of "Miss May I"'s albums, it gave me a tobuscus song as one of them. Thats when i knew something was up.
DO NOT DEAL WITH THIS MEMBER
Downloading now man, looks awesome!
That has to be one of the best backgrounds I've seen
Jul 31, 2012 02:29 AM
(This post was last modified: Jul 31, 2012 03:02 AM by Weakky..)
(Jul 30, 2012 08:20 PM)Eternal Darkness Wrote: Guesstimated based on small amount of songs tested while optimizing the code.
Has about a .75% chance of getting the song. Based on my experience.
5% of the time it finds a different song with the same title (not really a fault, probably should search with artists name or something). 20% of the time it doesn't download because of the youtube-mp3 problems.
Not bad, but needs a new method to be efficient currently. xD
Thanks for your statistic :P.. - Yeah, I think that I've made a mistake. I'm not on my PC now, but I think that the program search song with the song name only. I'll add the artist name before the song name, and it should find all songs with a higher percentage :).
And thanks for all others comment. Appreciated.
EDIT: Well. Binary version updated. It now search with "artist name song name". I have no idea if it will change something. It was only one line, so I didn't update the source code version. Change it yourself if you want.
Besides the fact that you download the songs from youtube, this is really nice
Jul 31, 2012 03:27 AM
(This post was last modified: Jul 31, 2012 03:40 AM by Weakky..)
Yeah I know, songs are poor quality ; 128 kbps :(.. But Youtube is probably the most complete song website :/.. Thanks anyway for the comment man :).
(Jul 31, 2012 03:24 AM)BlackCap Wrote: Besides the fact that you download the songs from youtube, this is really nice
Yea when I first looked on this thread yesterday, I had hopes it was downloading songs directly from itunes..
I skimmed trough the code and found out it was downloading(With a third part website) from youtube, based on the artist and songname.
But it seems to be a great program and well written
Jul 31, 2012 07:22 AM
(This post was last modified: Jul 31, 2012 07:23 AM by Weakky..)
(Jul 31, 2012 06:58 AM)Moen Wrote: Yea when I first looked on this thread yesterday, I had hopes it was downloading songs directly from itunes..
I skimmed trough the code and found out it was downloading(With a third part website) from youtube, based on the artist and songname.
But it seems to be a great program and well written
Downloading songs directly from itunes is probably impossible man xD.. And if I had done that, I would never give the source code 😊.
I'm currently working on a MP3Skull Version, which would download only 320kpbs songs.
Jul 31, 2012 10:56 AM
(This post was last modified: Jul 31, 2012 10:56 AM by BlackCap.)
(Jul 31, 2012 06:58 AM)Moen Wrote: Yea when I first looked on this thread yesterday, I had hopes it was downloading songs directly from itunes..
I skimmed trough the code and found out it was downloading(With a third part website) from youtube, based on the artist and songname.
But it seems to be a great program and well written
I went straight to the main.vb file and almost got scared back out, you wrote so unorginized! I mean if I am in a haste or are testing out something, I also write quite messy, but I use to orginize the code afterwords to make it readable for later.
You should sort most stuff into Regions to make the code easier to navigate.
Always separate methods by a empty line unless they overloads eachother.
Make your If statements as short and easy as possible, ex:
Code If Not SongName = Nothing
Code If SongName IsNot Nothing
Instead of putting a gigantic block of code into a if, use:
Code If True Then Exit Sub
If True Then Exit Property
If True Then Exit Do
If True Then Continue For
If True Then Continue While
Besides that, you seem to know what you are doing. Something which I cannot say for most sources I've had a look on at HF, that's why i'm bitching at you ^^
(Jul 31, 2012 10:56 AM)BlackCap Wrote: I went straight to the main.vb file and almost got scared back out, you wrote so unorginized! I mean if I am in a haste or are testing out something, I also write quite messy, but I use to orginize the code afterwords to make it readable for later.
You should sort most stuff into Regions to make the code easier to navigate.
Always separate methods by a empty line unless they overloads eachother.
Make your If statements as short and easy as possible, ex:
Code If Not SongName = Nothing
Code If SongName IsNot Nothing
Instead of putting a gigantic block of code into a if, use:
Code If True Then Exit Sub
If True Then Exit Property
If True Then Exit Do
If True Then Continue For
If True Then Continue While
Besides that, you seem to know what you are doing. Something which I cannot say for most sources I've had a look on at HF, that's why i'm bitching at you ^^
I'm not gonna react as yesterday with Tedd, 'cause instead of simply bitching me, you gave me some tips.
Well. I know that my codes are not clean and unorganized..
But as I said to Tedd yesterday, I'm only 15, and I've been learning .NET by myself, looking to source code and using google. Alone, and without any fucking help. And now, I'm full of bad habits.
So yeah, that's true, it's horrible, and I'm sorry to don't have the skill to create something better. But nobody learnt me to organize my source code, and if I had the skill to do it, I would not share something like that. Thanks anyway for reading me and for your tips. 🤝.
(Jul 31, 2012 11:31 AM)Weakky. Wrote: I'm not gonna react as yesterday with Tedd, 'cause instead of simply bitching me, you gave me some tips.
Well. I know that my codes are not clean and unorganized..
But as I said to Tedd yesterday, I'm only 15, and I've been learning .NET by myself, looking to source code and using google. Alone, and without any fucking help. And now, I'm full of bad habits.
So yeah, that's true, it's horrible, and I'm sorry to don't have the skill to create something better. But nobody learnt me to organize my source code, and if I had the skill to do it, I would not share something like that. Thanks anyway for reading me and for your tips. 🤝.
All the tips he gave you can be summarized into one word. OOP (Object Oriented Programming). Start with that, afterwards learn patterns when you master OOP.
|