Home Upgrade Search Memberlist Extras Hacker Tools Award Goals Help Wiki Contact

Post Editing Changes

(Mar 7, 2018 07:05 PM)xadamxk Wrote:  10 edits in 2 months?

RIP sales threads and advanced tutorials.

I was kind of thinking the same for specific sales threads, for example people who keep a updated inventory or balance for CE.
(Mar 7, 2018 07:05 PM)Xerotic Wrote:  Gives me some badly parsed MyCode as well. However I do not believe this is an issue with this plugin. I believe that it may be an issue with your formatting. The 1.8 parser seems to work differently and can be “finicky”.

When I’m on my desktop I’ll take a closer look at your MyCode but I believe formatting is the issue here.

I've narrowed it down to aligning [code].

The error occurs when the [code] in my thread is aligned.

Will be sending you a new pastebin.



EDIT:

Just tried posting it over at KnotBB.

Unless you have implimented the new editing plugin there, it is a formatting issue.
[Image: XeoMD0Q.gif]
Will there be an additional limitation lift on edits depending on the status you have on HF? (L33T, UB3R, R3KT).
As someone who plans to write additional threads that may require extensive edits over a course of a month, I find that this may hinder that situation.
(Mar 7, 2018 07:05 PM)xadamxk Wrote:  10 edits in 2 months?

RIP sales threads and advanced tutorials.

Also was thinking about the sales thread. So practically only 10 edits in 2 months if done with an hour's gap.
10 edits in the same day in 10 hours, boom!! No longer editing, hence new threads(Cross posting) -> More work for staff, deleting and warning people.

Hope this limit doesn't apply to Original Post(OP).
This is great, thank you for adding this.
[Image: 3.png]

I really like this feature. Great work Omniscient and Xerotic.
kitty had a snack
Damn. This is gunna be annoying on my sales thread if I can't edit the status ect.
Would this affect the titles of the threads also or just the posts?
(Mar 8, 2018 07:49 AM)The Unknown Coder Wrote:  Would this affect the titles of the threads also or just the posts?

Thread title edits are the same as thread content edits (from MyBB's view).
(Mar 8, 2018 12:53 AM)wraxu Wrote:  Damn. This is gunna be annoying on my sales thread if I can't edit the status ect.

After 60 days pass I think you're able to again
[Image: oGzLpzM.gif]
Quote:The hour begins when the post is created. After one hour from the post creation every edit will be logged.


Ahh, that makes more sense now. :) I was slightly confused about how that worked.

But I'm noticing something. The posts where the edit isn't saved because it's within that hour the (view edit history) link is there but of course it goes to nothing. I know it would take a query to remove that so probably not worth it.

Quote:Gives me some badly parsed MyCode as well. However I do not believe this is an issue with this plugin.


Be careful because it could be MyBB and the way the hooks are. A couple of the MyBB hooks are used twice. In such an instance a parser might double up. Look for that when hunting that down. I've complained to them about this and they have it marked to get fixed. Really dumb of them to use the same hook twice. This is why you might have to change the hooks you use or we may just need to alter the code ourselves to fix this.

Quote:10 edits in 2 months?

RIP sales threads and advanced tutorials.


I may alter it. But for the immediate future we'll see how this goes. I can easily prune after 30 days but allow 15 edits. The real goal of this plugin is to prevent edit abuse. To give staff, mentors, and admins enough time to find someone abusing edits and revert them then give them a very long ban. 60 days should be more than enough time but 30 may do as well. And the amount of edits is set to 10 for now just to see how much the table in the DB gets used. I really have no idea the amount of post editing that goes on. But since the plugin was enable there has been 330 edits saved. Seems like a lot to me. About 30,000 entries for 60 days.


Quote:I know i make more than 10 edits a week with the wiki


I am upping it to 15 for now. I know some of you have special needs. We do have the ability to exempt some groups from the limit and we may end up doing just that.

Quote:I've narrowed it down to aligning [code].

The error occurs when the [code] in my thread is aligned.


I can tell you the align code with 1.8x sucks.

Quote:Just tried posting it over at KnotBB.

Unless you have implimented the new editing plugin there, it is a formatting issue.


We did have it running there. I just deactivated it. So try now and if it still formats badly then it's MyBB parser.

Quote:Will there be an additional limitation lift on edits depending on the status you have on HF? (L33T, UB3R, R3KT).


It's very possible to be an upgrade feature. I may end up restricting the different groups for max edits in 60 days. I personally think it would be a good upgrade ability.

Quote:Hope this limit doesn't apply to Original Post(OP).


Actually it does apply to OP and that's actually where a lot of edit abuse occurs. Don't panic yet about the number. I see that there is some concern and we'll do our best to adjust this for our communities needs.

Quote:Would this affect the titles of the threads also or just the posts?


Good question. Yes, it does. But I see it's not actually saving the old subject. I'm going to have that fixed.

Quote:After 60 days pass I think you're able to again


This functions similar to the way reputations work. It's a rotating 60 day prune. So let's say you have 1 edit pruned on that 60th day. Now you have 9 in the queue and can make 1 edit.
(Mar 8, 2018 10:29 AM)Omniscient Wrote:  But I'm noticing something.  The posts where the edit isn't saved because it's within that hour the (view edit history) link is there but of course it goes to nothing.  I know it would take a query to remove that so probably not worth it.

By-product of altering the plugin to suit HF posts table needs. Figured I'd save showthread.php a query.

(Mar 8, 2018 10:29 AM)Omniscient Wrote:  We do have the ability to exempt some groups from the limit and we may end up doing just that.

It's very possible to be an upgrade feature.  I may end up restricting the different groups for max edits in 60 days.  I personally think it would be a good upgrade ability.

🤩

(Mar 8, 2018 10:29 AM)Omniscient Wrote:  Good question.  Yes, it does. But I see it's not actually saving the old subject.  I'm going to have that fixed.

🤩
[Image: DE93-ABEA-2-E28-4-F9-D-9-BB6-312-B3328937-E.png]
(Mar 8, 2018 10:29 AM)Omniscient Wrote:  I may alter it.  But for the immediate future we'll see how this goes.  I can easily prune after 30 days but allow 15 edits.   The real goal of this plugin is to prevent edit abuse.  To give staff, mentors, and admins enough time to find someone abusing edits and revert them then give them a very long ban.  60 days should be more than enough time but 30 may do as well.  And the amount of edits is set to 10 for now just to see how much the table in the DB gets used.  I really have no idea the amount of post editing that goes on.  But since the plugin was enable there has been 330 edits saved.  Seems like a lot to me.  About 30,000 entries for 60 days.  

A good portion of those edits was me trying to figure out what the problem with my formatting was. Sorry about that Omni.
[Image: XeoMD0Q.gif]
Your improvments to the existing plugin seem really nice Xerotic, any plans to contribute back to the upstream? I know that Starpaul would certainly appreciate it.
Sounds really good Omni. I think it would be a great idea to add additional editing ability as a perk for UB3R/R3KT members.

Not unlimited, but just do something like so:
  • Normal Members: 15

  • L33T Members: 20

  • UB3R Members: 25

  • R3KT Members: 30



Of course I don't need to tell you which figure would belong to each usergroup, take my above list as an example of what I mean, not a recommendation on the number of edits.
Side note though: UB3R/3P1C members (together), receive the perk of 1 second searches. I think 1 second limits on edits would be a cool feature for them too, as I mostly edit directly after sending a message and noticing some grammar mistakes. Just a thought (happened on this post).


Possibly Related Threads...
Thread / Author Replies Views Last Post
[Account Help] by Jordana BrewsterJan 7, 2014 01:01 PM 3 247 Jan 7, 2014 01:01 PM
Last Post: Diabolic